Check uid type in Field Locator and handle if str #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #132 for original discussion My apologies @jacobtoppm ; I wanted to rename the branch to something more meaningful, not sure if there is a way to copy the discussion or rename the original PR to keep the discussion as is (and if there is, I'm sure I don't have the permissions) |
Currently nothing prevents a setup like ```WAGTAILTRANSFER_LOOKUP_FIELDS = {'wagtailcore.page': ['slug', 'locale_id']}``` from existing,
but this will cause issues trying to look up and match the page due to how it's currently sent in the admin_url
easherma-truth
force-pushed
the
fix-non-UID-lookup-for-wagtail-pages
branch
from
3783fb8
to
0f24e6b
Compare
easherma-truth
force-pushed
the
fix-non-UID-lookup-for-wagtail-pages
branch
from
0f24e6b
to
6f4de62
Compare
|
Closing in favor of #138 ; sorry for the mess 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133 Currently nothing prevents a setup like
WAGTAILTRANSFER_LOOKUP_FIELDS = {'wagtailcore.page': ['slug', 'locale_id']}from existing, but this will cause issues trying to look up and match the page due to how it's currently sent in the admin_url